Repository navigation
Conversation
The continuation-line indent check in `pushFlags()` was case-sensitive, so flags with an uppercase short form (`-H`, `-X`) were treated as having no short form and got four extra spaces. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
commit: |
apify-factory
previously approved these changes
Nov 9, 2026
apify-factory
left a comment
Contributor
There was a problem hiding this comment.
Looks good, nothing blocking.
🏭 Apify Factory auto approved ✅ — passed every gate without touching the sides
Every gate passed, and neither the reviewer nor a juror found anything a human needs to look at.
Approval locked to 86b478e60 · workflow run
apify-factory
dismissed
their stale review
November 10, 2026 08:50
Withdrawn because the content changed since the last verdict, and pushes are not re-reviewed.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
TL;DR — flags with an uppercase short form (
-H,-X) were indented four spaces deeper than lowercase ones in--help, so the FLAGS block didn't line up. The indent check was case-sensitive. One-character fix:/^-[a-z]/→/^-[a-z]/i. Onlyapify apihas uppercase short flags, so only its help and itsdocs/reference.mdblock change.apify api --help, before:After:
Long-only flags such as
--profilekeep their four-space indent, which is what that branch is for.Adds a regression test that fails on the old regex, and regenerates
docs/reference.md.🤖 Generated with Claude Code