Skip to content

ci: build docs from the lockfile instead of re-resolving the theme - #1554

Open
l2ysho wants to merge 4 commits into
masterfrom
claude/apify-cli-workflow-failure-867584
Open

l2ysho wants to merge 4 commits into
masterfrom
claude/apify-cli-workflow-failure-867584

Conversation

@l2ysho

@l2ysho l2ysho commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Note

The docs build ran pnpm add @apify/docs-theme@latest, which re-resolves the whole website tree outside the lockfile and trips this repo's 7-day minimumReleaseAge. Docs deploys have been red since 2026-11-04. This builds from the lockfile instead. The theme now has to arrive via Renovate, and that path is stuck today — see Notes.

Problem

  • P1 pnpm add @apify/docs-theme@latest resolves a fresh tree, so every transitive dependency faces minimumReleaseAge: 10080 (7 days). minimumReleaseAgeExclude covers @apify/*, not what the theme pulls in.
  • P2 The theme's postcss/@csstools chain republishes far more often than weekly. On 2026-11-04 it rejected 37 versions, on 2026-11-05 still 22.
  • P3 Four consecutive docs runs failed with ERR_PNPM_NO_MATURE_MATCHING_VERSION. The Install pnpm and dependencies step passed every time — only the fresh resolve failed.

Change

  • C1 Drop the pnpm add @apify/docs-theme@latest line. The job now installs from the lockfile and builds, same as the Docs build job in check.yaml.
  • C2 Drop the Commit the updated package(-lock).json step — nothing changes those files any more.
  • C3 Drop the now-unused service-account PAT from checkout and from the build step's GIT_USER / GH_TOKEN, and narrow the job to contents: read. Nothing in scripts/, website/ or the theme reads either variable. The CloudFront step keeps its own token.

Notes

  • N1 apify/apify-docs publishes the theme and then dispatches docs.yaml here and in apify-sdk-js / apify-client-js. After this change the dispatch still rebuilds and redeploys, but can only ship the theme already in the lockfile.
  • N2 Both siblings run pnpm update @apify/docs-theme and set minimumReleaseAge: 1440, so they are green and pin ^1.0.282. This repo pins ^1.0.278.
  • N3 The Renovate fallback is not delivering right now: renovate/lock-file-maintenance has been red since 2026-11-03, and automergeType: branch never merges a red branch.

Follow-ups

  • F1 Decide the delivery path: either lower minimumReleaseAge to 1440 to match the siblings and restore a pnpm update @apify/docs-theme step, or keep this change, unstick the Renovate branch, and drop apify/apify-cli from the rebuild-docs matrix in apify/apify-docs.
  • F2 Until F1 lands, the published CLI docs stay on theme 1.0.278 while the other two sites behind the same CloudFront distribution are on 1.0.282.

Verification

  • V1 actionlint .github/workflows/docs.yaml passes.
  • V2 Workflow YAML only — lint-staged matched no files, and no TypeScript, flags or commands changed, so docs/ needs no regeneration.

🤖 Generated with Claude Code

l2ysho and others added 2 commits November 5, 2026 16:52
The docs build ran `pnpm add @apify/docs-theme@latest`, which resolves a
fresh tree outside the lockfile. Every transitive dependency then has to
pass `minimumReleaseAge: 10080` (7 days), and the postcss/csstools chain
the theme pulls in is republished far more often than that, so the build
has been red since 2026-11-04.

Install from the lockfile instead and let Renovate move the pin.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Nothing in the job writes to the repository any more, and neither the
build scripts nor the theme read GH_TOKEN or GIT_USER. Checkout now uses
the default token and the job only needs contents: read. The CloudFront
invalidation keeps its own token, which it still needs.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@l2ysho
l2ysho requested a review from DaveHanns as a code owner November 5, 2026 16:02
@l2ysho l2ysho added adhoc Ad-hoc unplanned task added during the sprint. t-builders Issues owned by the Builders team. labels Nov 5, 2026
@pkg-pr-new

pkg-pr-new Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

npx https://pkg.pr.new/apify-cli@1554

commit: 013a0f0

@l2ysho
l2ysho marked this pull request as draft November 5, 2026 16:33
@l2ysho
l2ysho marked this pull request as ready for review November 9, 2026 20:48
@l2ysho
l2ysho requested a review from apify-factory November 9, 2026 20:48

@apify-factory apify-factory left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nothing blocking.

🏭 Factory review — ℹ️ not auto-approved

This change was reviewed but cannot be auto-approved: a gate failed, so the review cannot end in an approval.

check result
Static gates ❌ 14/16 — file-extensions, deny-globs
Review findings ✅ none
Reviewer escalation ❌ Changes the docs deployment workflow's token usage, permissions, and theme-delivery path, which a maintainer should confirm against the cross-repo dispatch setup.
Juror 1 — claude-sonnet-5-5, adversarial ⏭️ skipped — a gate failed
Why it was not auto-approved

Failed gates:

  • file-extensions: disallowed extension: .github/workflows/docs.yaml
  • deny-globs: .github/workflows/docs.yaml matches .github/**

The comments above are the review itself; this section only explains the approval decision. Push a change and request @apify-factory again to re-run it, or ask a human to review.

Reviewed 33abccc58 · workflow run

@l2ysho
l2ysho enabled auto-merge (squash) November 9, 2026 21:17

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-builders Issues owned by the Builders team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants