Repository navigation
Conversation
The docs build ran `pnpm add @apify/docs-theme@latest`, which resolves a fresh tree outside the lockfile. Every transitive dependency then has to pass `minimumReleaseAge: 10080` (7 days), and the postcss/csstools chain the theme pulls in is republished far more often than that, so the build has been red since 2026-11-04. Install from the lockfile instead and let Renovate move the pin. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Nothing in the job writes to the repository any more, and neither the build scripts nor the theme read GH_TOKEN or GIT_USER. Checkout now uses the default token and the job only needs contents: read. The CloudFront invalidation keeps its own token, which it still needs. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
commit: |
l2ysho
marked this pull request as draft
November 5, 2026 16:33
l2ysho
marked this pull request as ready for review
November 9, 2026 20:48
apify-factory
left a comment
Contributor
There was a problem hiding this comment.
Looks good, nothing blocking.
🏭 Factory review — ℹ️ not auto-approved
This change was reviewed but cannot be auto-approved: a gate failed, so the review cannot end in an approval.
| check | result |
|---|---|
| Static gates | ❌ 14/16 — file-extensions, deny-globs |
| Review findings | ✅ none |
| Reviewer escalation | ❌ Changes the docs deployment workflow's token usage, permissions, and theme-delivery path, which a maintainer should confirm against the cross-repo dispatch setup. |
Juror 1 — claude-sonnet-5-5, adversarial |
⏭️ skipped — a gate failed |
Why it was not auto-approved
Failed gates:
file-extensions: disallowed extension: .github/workflows/docs.yamldeny-globs: .github/workflows/docs.yaml matches .github/**
The comments above are the review itself; this section only explains the approval decision. Push a change and request @apify-factory again to re-run it, or ask a human to review.
Reviewed 33abccc58 · workflow run
l2ysho
enabled auto-merge (squash)
November 9, 2026 21:17
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
The docs build ran
pnpm add @apify/docs-theme@latest, which re-resolves the whole website tree outside the lockfile and trips this repo's 7-dayminimumReleaseAge. Docs deploys have been red since 2026-11-04. This builds from the lockfile instead. The theme now has to arrive via Renovate, and that path is stuck today — see Notes.Problem
pnpm add @apify/docs-theme@latestresolves a fresh tree, so every transitive dependency facesminimumReleaseAge: 10080(7 days).minimumReleaseAgeExcludecovers@apify/*, not what the theme pulls in.@csstoolschain republishes far more often than weekly. On 2026-11-04 it rejected 37 versions, on 2026-11-05 still 22.docsruns failed withERR_PNPM_NO_MATURE_MATCHING_VERSION. TheInstall pnpm and dependenciesstep passed every time — only the fresh resolve failed.Change
pnpm add @apify/docs-theme@latestline. The job now installs from the lockfile and builds, same as theDocs buildjob incheck.yaml.Commit the updated package(-lock).jsonstep — nothing changes those files any more.GIT_USER/GH_TOKEN, and narrow the job tocontents: read. Nothing inscripts/,website/or the theme reads either variable. The CloudFront step keeps its own token.Notes
apify/apify-docspublishes the theme and then dispatchesdocs.yamlhere and inapify-sdk-js/apify-client-js. After this change the dispatch still rebuilds and redeploys, but can only ship the theme already in the lockfile.pnpm update @apify/docs-themeand setminimumReleaseAge: 1440, so they are green and pin^1.0.282. This repo pins^1.0.278.renovate/lock-file-maintenancehas been red since 2026-11-03, andautomergeType: branchnever merges a red branch.Follow-ups
minimumReleaseAgeto1440to match the siblings and restore apnpm update @apify/docs-themestep, or keep this change, unstick the Renovate branch, and dropapify/apify-clifrom therebuild-docsmatrix inapify/apify-docs.Verification
actionlint .github/workflows/docs.yamlpasses.lint-stagedmatched no files, and no TypeScript, flags or commands changed, sodocs/needs no regeneration.🤖 Generated with Claude Code