Repository navigation
Conversation
- Retry transient failures when fetching the template manifest and downloading archives. A failed fetch made `apify create` exit early, so tests failed later with ENOENT or a missing dataset. - API tests wait for the Actor's `latest` build instead of reading the builds list right after push, which can still be empty. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
l2ysho
added
adhoc
commit: |
l2ysho
marked this pull request as ready for review
November 6, 2026 12:02
apify-service-account
added
the
tested
apify-factory
left a comment
apify-factory
left a comment
Contributor
There was a problem hiding this comment.
Looks good, nothing blocking.
🏭 Factory review — ℹ️ not auto-approved
This change was reviewed but cannot be auto-approved: a gate failed, so the review cannot end in an approval.
| check | result |
|---|---|
| Static gates | ❌ 15/16 — no-risky-content |
| Review findings | ✅ none |
| Reviewer escalation | ❌ Adds new retry behavior with delays to production network calls (template manifest fetch and every downloadZip caller, including actors pull), which is a runtime retry change beyond test-only fixes. |
Juror 1 — claude-sonnet-5-5, adversarial |
⏭️ skipped — a gate failed |
Why it was not auto-approved
Failed gates:
no-risky-content: src/lib/utils.ts: network call (network-call); test/local/lib/utils.test.ts: network call (network-call)
The comments above are the review itself; this section only explains the approval decision. Push a change and request @apify-factory again to re-run it, or ask a human to review.
Reviewed f2fd44cde · workflow run
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
TL;DR Fixes the 3 open apify-cli flakes from the flake triage log (2026-09-24 sweep).
Changes
src/lib/utils.ts,src/commands/create.ts): the manifest fetch retries on any error. The archive download retries on network errors and HTTP 408/429/5xx. 3 attempts, 1s then 2s delay. Other 4xx errors still fail at once.python-scrapy-template-works.test.ts(4/48) andpython/works-with-spaces-in-path-to-actor.test.ts(2/48). Also fixes a single ENOENT sighting inpropagates-non-zero-exit-code.test.ts.createinstalls dependencies. The ENOENT paths (my_actor/main.py,src/) show the archive was never unzipped. Vitest runs silent, so thecreateerror never reached the log.latestbuild (test/__setup__/build-utils.ts):call.test.tsandtask/run.test.tsnow polltaggedBuilds.latest(60s limit) and do not readbuilds().list()right after push. That list can still be empty, which causedlastBuildto be undefined incall.test.ts(2/48).Follow-ups
push.ts,templates/ls.tsandwrapScrapyProject.tsalso callfetchManifest()without a retry. I left them out to keep this diff small.🤖 Generated with Claude Code