fix(gateway): decouple outbound CA trust store from tls.enabled; add README examples#320
Merged
Merged
Conversation
The README only had the auto-generated values table, which does not show how to actually use multi-field values like additionalTrustedCAs. Add a Configuration examples section (rendered from README.md.gotmpl) covering: trusting additional outbound CAs, exposing via LoadBalancer, setting replicas/resources, and injecting extra env vars. 3.9 line of the main-branch change.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
ct lint runs with --charts (explicit list), which disables version-increment checking, so a docs-only README change does not require a Chart.yaml bump.
ssl_trusted_certificate is the gateway's OUTBOUND trust store (used to verify etcd/Control Plane, openid-connect, loggers and other services the gateway dials). It has nothing to do with the inbound HTTPS listener, but existingCASecret and additionalTrustedCAs were gated on gateway.tls.enabled, so with the listener disabled the trust store (and its Secret mounts) silently disappeared even though etcd.auth.tls.verify or an openid-connect ssl_verify still needs it. Gate the config rendering and the Secret mounts on whether a CA is actually configured, not on gateway.tls.enabled. No change for the default (tls.enabled true); only fixes the tls.enabled=false case. Also revert the misleading tls.enabled note added to the README examples.
jarvis9443
changed the title
nic-6443
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: outbound CA trust store was gated on the inbound TLS listener
apisix.ssl.ssl_trusted_certificateis the gateway's outbound trust store — it verifies the TLS certificates of services the gateway dials (etcd/Control Plane,openid-connectIdPs, loggers, ...). It has nothing to do with the inbound HTTPS listener (gateway.tls.enabled).But
gateway.tls.existingCASecretandgateway.tls.additionalTrustedCAs(added in #318) were both gated ongateway.tls.enabled. So with the HTTPS listener disabled, the trust store and its Secret mounts silently disappeared — even thoughetcd.auth.tls.verify: trueor anopenid-connectssl_verify: truestill needs them.This gates the
ssl_trusted_certificaterendering and the CA Secret mounts on whether a CA is actually configured, not ongateway.tls.enabled:gateway.tls.enabled: true).gateway.tls.enabled: falsecase.Docs: configuration examples
Also adds a Configuration examples section to
README.md.gotmpl(regenerated intoREADME.md). CoversadditionalTrustedCAs, exposing via LoadBalancer, replicas/resources, and extra env vars.Chart version bumped
3.9.6→3.9.7(functional fix). 3.9 line of #319.