Repository navigation
Prevent continuous release race when merging multiple PRs - #166
Merged
Merged
Conversation
When several PRs are merged together, an older run could finish last and try to move the continuous tag backwards, failing with 422. Serialise the continuous_release job and skip it when the run's commit is no longer the head of main. Also await the tag update so errors fail the step cleanly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When several PRs are merged in quick succession, their push runs overlap. The run for #160 finished last and tried to move the
continuoustag back to its older commit, failing with422 Reference cannot be updated(run 37764426649).Changes to
continuous_release:concurrencygroup so release jobs run one at a time.main; if not, post a notice and skip the tag/release steps (also prevents an outdated zip overwriting a newer one).awaitthe tag update so real errors fail the step cleanly.