ZOOKEEPER-5082: Remove special characters from audit logs - #2448
Merged
Conversation
tisonkun
reviewed
Aug 31, 2026
tisonkun
left a comment
tisonkun
left a comment
Member
There was a problem hiding this comment.
I must lose some context but why whitespace characters be sensitive or should be removed from the audit log?
Contributor
Author
It gives ability to the client to inject fake lines to the audit log. e.g. Add a '\n' to value and insert your forged line after it which will appear as a valid entry. See the attached Jira tickets for more context. |
Contributor
Author
|
Added a commit to consolidate with what we already have in |
PDavid
approved these changes
Sep 1, 2026
PDavid
left a comment
PDavid
left a comment
Contributor
There was a problem hiding this comment.
Many thanks for fixing this. 👍
asf-gitbox-commits
pushed a commit
that referenced
this pull request
Sep 1, 2026
Reviewers: tisonkun, phunt, PDavid Author: anmolnar Closes #2448 from anmolnar/ZOOKEEPER-5082 (cherry picked from commit e4f0cd4) Signed-off-by: Andor Molnar <andor@cloudera.com>
asf-gitbox-commits
pushed a commit
that referenced
this pull request
Sep 1, 2026
Reviewers: tisonkun, phunt, PDavid Author: anmolnar Closes #2448 from anmolnar/ZOOKEEPER-5082 (cherry picked from commit e4f0cd4) Signed-off-by: Andor Molnar <andor@cloudera.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related:
cc @ztzg @eolivelli @tisonkun