Skip to content

ZOOKEEPER-5075: Upgrade JLine to 3.30.14 - #2436

Merged
anmolnar merged 2 commits into
apache:masterfrom
IshaPatil05817:ZOOKEEPER-5075-upgrade-jline
Aug 27, 2026
Merged

ZOOKEEPER-5075: Upgrade JLine to 3.30.14#2436
anmolnar merged 2 commits into
apache:masterfrom
IshaPatil05817:ZOOKEEPER-5075-upgrade-jline

Conversation

@IshaPatil05817

Copy link
Copy Markdown
Contributor

What changes were made?

Upgraded the JLine dependency from 3.25.1 to 3.30.14 in pom.xml.

##Verification

  • Successfully built the project using:
    mvn clean install -DskipTests

@PDavid PDavid left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks, looks good to me. 👍

@anmolnar anmolnar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the license file here:

/zookeeper-server/src/main/resources/lib/jline-3.25.1.LICENSE.txt

@anmolnar
anmolnar merged commit 100001f into apache:master Aug 27, 2026
16 of 17 checks passed
@anmolnar

Copy link
Copy Markdown
Contributor

Merged. Thanks @IshaPatil05817 !

@PDavid

PDavid commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Hi @anmolnar,
I'm not sure if you plan to backport this to older branches if yes, please be aware of this:

Note: For older branches which support Java 8 max, we should use the jdk8 classifier of jline. The newer versions have features that only work with java 22+ and this trips up the org.codehaus.mojo.extraenforcer.dependencies.EnforceBytecodeVersion maven plugin with zookeeper.

See: #2329 (comment)

asf-gitbox-commits pushed a commit that referenced this pull request Sep 1, 2026
Reviewers: PDavid, anmolnar
Author: IshaPatil05817
Closes #2436 from IshaPatil05817/ZOOKEEPER-5075-upgrade-jline

(cherry picked from commit 100001f)
Signed-off-by: Andor Molnar <andor@cloudera.com>
asf-gitbox-commits pushed a commit that referenced this pull request Sep 1, 2026
Reviewers: PDavid, anmolnar
Author: IshaPatil05817
Closes #2436 from IshaPatil05817/ZOOKEEPER-5075-upgrade-jline

(cherry picked from commit 100001f)
Signed-off-by: Andor Molnar <andor@cloudera.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants