Repository navigation
[ZEPPELIN-6757] Remove Helium support - #5582
Conversation
tbonelee
left a comment
There was a problem hiding this comment.
Thanks for taking on this cleanup.
Could you rebase this PR onto master and remove the extra divider left in the docs site's More dropdown after removing the Helium section?
f8d5fba to
5087b8c
Compare
|
Thanks @tbonelee. Rebased onto master ( The rebase preserves the newer HTML warning-dismissal behavior and its regression test alongside the built-in visualization tests. All 319 Angular shell tests pass, as do the frontend production build, result-component lint/format checks, SDK typecheck, and WebSocket contract checks. I also checked the navigation in a source-derived preview at desktop and narrow widths. Docker is unavailable locally, so I could not run the full Jekyll documentation build. The PR description now separates current checks from the earlier implementation validation. |
tbonelee
left a comment
There was a problem hiding this comment.
Thanks for the update. The rebase and divider fix look good.
With SystemJS removed, Monaco no longer exposes its global API, but the editor and theme code still rely on it. This throws during edit handling and prevents changes from being saved.
I tried replacing those global references with explicit imports in e4739faea. All 320 shell tests and focused browser checks for saving, reloading, collaboration, theme switching, and table pagination passed locally.
Could you update the remaining references along these lines?
What is this PR for?
Remove Helium Applications, Spells, external visualization packages, the registry/bundler, and related APIs, UI, RPCs, configuration, examples, and documentation in one change.
Preserve built-in tables/charts, ordinary interpreters, ResourcePool, and
%angular. Keep legacy application metadata and chart settings when saving notes; unavailable external visualizations display as Table. Replacement visualizations are outside this change.What type of PR is it?
Improvement
What is the Jira issue?
ZEPPELIN-6757
How should this be tested?
Rebased onto
apache/master5a74f537b; current head:5087b8ce2.Validated on the rebased head with Node.js 22.23.4:
Earlier implementation validation, before this rebase:
The full Jekyll documentation build remains unverified locally because Docker is unavailable. The source-derived navigation preview does not replace that build. GitHub CI must be checked on the rebased head; the previous head had failed npm-audit and Playwright E2E checks.
Questions