Skip to content

[ZEPPELIN-6629] Fix anchor links hidden under navbar #5407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tbonelee merged 3 commits into from
Oct 5, 2026
+10 −18
Merged

[ZEPPELIN-6629] Fix anchor links hidden under navbar #5407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e99df98
[ZEPPELIN-6629] Fix anchor links hidden under navbar
world970511 Aug 9, 2026
e8d8db9
Merge branch 'master' into ZEPPELIN-6629
world970511 Oct 5, 2026
e941001
[ZEPPELIN-6629] Tie navbar height values to a single CSS variable
world970511 Oct 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions docs/assets/themes/zeppelin/css/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@
@import url('../font/fonts-patua-one.css');
@import url('../font/fonts-open-sans.css');

:root {
--navbar-height: 60px;
}

body {
padding-top: 50px;
padding-bottom: 20px;
Expand All @@ -11,6 +15,10 @@ body {
font-size: 15px;
}

html {
scroll-padding-top: var(--navbar-height);
}

.jumbotron {
background-color: #3071a9;
}
Expand Down Expand Up @@ -86,7 +94,7 @@ body {
.navbar {
background: #3071a9;
border-bottom: 0px;
height: 60px;
height: var(--navbar-height);
box-shadow: 0px 3px 6px rgba(0, 0, 0, 0.4);
}

Expand Down Expand Up @@ -548,7 +556,7 @@ a.anchor {
}

.navbar-collapse.collapse {
max-height: 60px;
max-height: var(--navbar-height);
}

.navbar-inverse .navbar-nav a .caret,
Expand Down
16 changes: 0 additions & 16 deletions docs/assets/themes/zeppelin/js/docs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,15 +96,6 @@ function viewSolution() {
});
}

// A script to fix internal hash links because we have an overlapping top bar.
// Based on https://github.com/twitter/bootstrap/issues/193#issuecomment-2281510
function maybeScrollToHash() {
if (window.location.hash && $(window.location.hash).length) {
var newTop = $(window.location.hash).offset().top - 57;
$(window).scrollTop(newTop);
}
}

$(function() {
codeTabs();
// Display anchor links when hovering over headers. For documentation of the
Expand All @@ -114,10 +105,6 @@ $(function() {
};
anchors.add();

$(window).bind('hashchange', function() {
maybeScrollToHash();
});

$(document).ready(function() {
$('#toc').toc();
});
Expand All @@ -131,7 +118,4 @@ $(function() {
}
});

// Scroll now too in case we had opened the page on a hash, but wait a bit because some browsers
// will try to do *their* initial scroll after running the onReady handler.
$(window).load(function() { setTimeout(function() { maybeScrollToHash(); }, 25); });
});
Loading