[ZEPPELIN-6536] Stabilize notebook keyboard shortcut e2e editor seeding#5304
Open
voidmatcha wants to merge 2 commits into
Open
[ZEPPELIN-6536] Stabilize notebook keyboard shortcut e2e editor seeding#5304voidmatcha wants to merge 2 commits into
voidmatcha wants to merge 2 commits into
Conversation
jongyoul
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This PR stabilizes the notebook keyboard-shortcut e2e suite by avoiding keyboard-driven fixture seeding in the Monaco editor.
In the Firefox Playwright job, setup could trigger Monaco suggestions while typing fixture content. That let Enter accept a suggestion before the shortcut assertion ran, corrupting expected text, for example
linebecominglicense.The helper now seeds fixture text through the editor textarea without shortcut-style key events. The shortcut assertions still use real keyboard events.
This also re-enables the clone-content shortcut coverage now that #5254 has been merged. The skip is no longer needed, and keeping it would leave that shortcut path without regression coverage.
What type of PR is it?
Bug Fix
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-6536
How should this be tested?
Screenshots (if appropriate)
N/A
Questions: