[ZEPPELIN-6539] Fix DockerClient / container resource leaks on interpreter failure paths#5302
Open
hyunw9 wants to merge 3 commits into
Open
[ZEPPELIN-6539] Fix DockerClient / container resource leaks on interpreter failure paths#5302hyunw9 wants to merge 3 commits into
hyunw9 wants to merge 3 commits into
Conversation
tbonelee
reviewed
Jul 15, 2026
| // Best-effort removal of a container that was (partially) created during start(). | ||
| private void cleanupContainerQuietly() { | ||
| try { | ||
| docker.killContainer(containerName); |
Contributor
There was a problem hiding this comment.
Suggestion (non-blocking): In cleanupContainerQuietly(), killContainer and removeContainer share one try, so if killContainer throws (e.g. the container was created but never started, so it isn't running), removeContainer is skipped and the container is still leaked. Could we run them independently so removeContainer always fires?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
The Docker interpreter launcher (DockerInterpreterProcess) can leak resources on error paths when interpreters are started/stopped repeatedly by notebook workloads.
What type of PR is it?
Bug Fix
Todos
What is the Jira issue?
How should this be tested?
Automated unit tests added in DockerInterpreterProcessTest (DockerClient is mocked):
Screenshots (if appropriate)
Questions: