Skip to content

[Tests][TIRx] Localize hardware test gates#19985

Merged
tqchen merged 1 commit into
apache:mainfrom
tlopex:ci/tirx-localize-hardware-gates
Jul 14, 2026
Merged

[Tests][TIRx] Localize hardware test gates#19985
tqchen merged 1 commit into
apache:mainfrom
tlopex:ci/tirx-localize-hardware-gates

Conversation

@tlopex

@tlopex tlopex commented Jul 11, 2026

Copy link
Copy Markdown
Member

This PR removes the suite-wide TIRx compute-capability gate and localizes hardware skips to CUDA codegen and tile-primitive tests. It keeps the original test parameterization unchanged, allowing parser, printer, IR, transform, and other non-hardware TIRx tests to run in regular CI while device-dependent cases are skipped when SM100 hardware is unavailable. CUDA codegen helpers use explicit target architectures where needed, and the run-only benchmark utility tests retain a local SM100 gate.

This intentionally avoids adding separate compile/run parameter cases. A follow-up PR can audit slow frontend execution tests and define a focused runtime regression budget for real TIRx kernels.

Local validation:

  • pytest -n auto -m "not gpu" tests/python/tirx: 486 passed, 79 skipped.
  • pytest -n auto -m gpu tests/python/tirx without matching hardware: 1509 skipped.
  • Pre-commit passed on all changed files.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the suite-level hardware gate for TIRX tests, updates target handling in CUDA codegen tests, and adds @pytest.mark.gpu decorators to several test cases. Feedback focuses on correcting an inaccurate return type annotation in _get_source and removing the @pytest.mark.gpu decorators from compile-only tests. Since these compile-only tests do not execute on physical hardware, removing the decorators and specifying concrete target architectures (like sm_90a or sm_100a) inside the tests will allow them to run in CPU-only CI environments.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread tests/python/tirx/codegen/test_codegen_cuda.py Outdated
Comment thread tests/python/tirx/operator/tile_primitive/cuda/copy/test_reg.py
@tlopex
tlopex force-pushed the ci/tirx-localize-hardware-gates branch from 5329af1 to afc143a Compare July 11, 2026 18:48
@tlopex

tlopex commented Jul 11, 2026

Copy link
Copy Markdown
Member Author

@tvm-bot rerun

@tlopex
tlopex force-pushed the ci/tirx-localize-hardware-gates branch 3 times, most recently from 7dd8061 to eee3e5e Compare July 13, 2026 01:46
@tlopex tlopex changed the title [CI][Tests] Localize hardware test gates [CI][TIRx] Localize hardware gates to GPU execution Jul 13, 2026
@tlopex
tlopex force-pushed the ci/tirx-localize-hardware-gates branch from eee3e5e to 409f503 Compare July 13, 2026 02:52
@tlopex tlopex changed the title [CI][TIRx] Localize hardware gates to GPU execution [CI][TIRx] Enable compile coverage and fix exposed regressions Jul 13, 2026
@tlopex
tlopex force-pushed the ci/tirx-localize-hardware-gates branch 2 times, most recently from 41829d3 to 7942ab3 Compare July 13, 2026 03:53
@tlopex tlopex changed the title [CI][TIRx] Enable compile coverage and fix exposed regressions [CI][TIRx] Compile tests before GPU execution gates Jul 13, 2026
@tlopex
tlopex force-pushed the ci/tirx-localize-hardware-gates branch 2 times, most recently from edcf5d6 to 74d2592 Compare July 14, 2026 01:08
@tlopex tlopex changed the title [CI][TIRx] Compile tests before GPU execution gates [CI][TIRx] Localize hardware test gates Jul 14, 2026
@tlopex
tlopex force-pushed the ci/tirx-localize-hardware-gates branch 2 times, most recently from 9f6cc6e to a463a1b Compare July 14, 2026 12:36
@tlopex
tlopex force-pushed the ci/tirx-localize-hardware-gates branch from a463a1b to 9ba68e1 Compare July 14, 2026 12:46
@tlopex tlopex changed the title [CI][TIRx] Localize hardware test gates [Tests][TIRx] Localize hardware test gates Jul 14, 2026
@tqchen
tqchen merged commit fa903cf into apache:main Jul 14, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants