fix(cpp): align the ANTLR4 compatibility bound with the enforced range - #965
Merged
Merged
Conversation
ANTLR4Dependency.cmake accepts system ANTLR4 versions from 4.9.3 up to but excluding 4.13.0, because the C++ runtime shipped by 4.13 and newer requires C++17 while TsFile still builds as C++11/14. The documentation and the dependency test did not reflect that boundary: both READMEs advertised an upper bound of 5.0.0 and the test fixture marked 5.0.0 as the incompatible version. A regression that widened the accepted range would therefore pass the test suite. Update the two READMEs and pin the incompatible fixture to 4.13.0 so the boundary itself is covered.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #965 +/- ##
========================================
Coverage 63.95% 63.96%
========================================
Files 758 758
Lines 53253 53253
Branches 8445 8445
========================================
+ Hits 34060 34061 +1
+ Misses 17530 17529 -1
Partials 1663 1663 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ANTLR4Dependency.cmake accepts system ANTLR4 versions from 4.9.3 up to but excluding 4.13.0, because the C++ runtime shipped by 4.13 and newer requires C++17 while TsFile still builds as C++11/14.
The documentation and the dependency test did not reflect that boundary: both READMEs advertised an upper bound of 5.0.0 and the test fixture marked 5.0.0 as the incompatible version. A regression that widened the accepted range would therefore pass the test suite.
Update the two READMEs and pin the incompatible fixture to 4.13.0 so the boundary itself is covered.
History
TSFILE_ANTLR4_NEXT_INCOMPATIBLE_VERSION = "5.0.0", and both READMEs documented that same bound, so code and docs agreed at the time.4.13.0- the C++ runtime shipped by ANTLR4 4.13 and newer requires C++17, while TsFile's public baseline is C++11 - but only the CMake variable and its comment were updated. The two READMEs and the dependency test kept5.0.0.