Repository navigation
Increase default maxLocaleCount to 20 and complete doc/log updates - #1170
Open
aleksievelizhanin wants to merge 1 commit into
Open
aleksievelizhanin wants to merge 1 commit into
aleksievelizhanin wants to merge 1 commit into
Conversation
aleksievelizhanin
force-pushed
the
fix/max-locale-count
branch
from
November 15, 2026 08:59
4588e42 to
d30df8a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to
c639c7ef99and1665d6b107after transitioningmaxLocaleCountfrom rejecting requests to ignoring extra locales:Connector.maxLocaleCountfrom10to20. Chromium-based browsers (Edge, Chrome) automatically expand each configured regional language (lang-REGION) with its base language fallback (lang), so a user profile with 6 regional languages already sends 11–12 language tags inAccept-Language.Connector.getMaxLocaleCount()andConnector.setMaxLocaleCount()Javadocs, which still stated that requests exceeding the limit are rejected.Request.maxLocaleCountJavadoc and theparseLocalesHeader()comment (loggedinstead ofrejected).coyoteRequest.tooManyLocalesinLocalStrings.propertiesto state that locales beyond the limit have been ignored (consistent withparameters.maxCountFail).mbeans-descriptors.xml,http.xml,ajp.xml,changelog.xml, andTestRequest.javato reflect the default of20.