Remove extract-zip from TypeScript test dependencies - #3747
Open
kpumuk wants to merge 1 commit into
Open
Conversation
Client: js,ts Co-Authored-By: OpenAI Codex (GPT-5.6) <codex@openai.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the TypeScript browser test toolchain in lib/ts to remove the extract-zip dependency by upgrading the Grunt QUnit runner stack and aligning the downloaded QUnit assets with the plugin’s expected event API.
Changes:
- Bump
grunt-contrib-qunitto^10.2.0and pin its Puppeteer runner to25.8.0viaoverrides. - Update QUnit assets downloaded for TS tests to
2.26.0and switch those downloads to HTTPS. - Regenerate
lib/ts/package-lock.jsonto reflect the new dependency tree (removingextract-zipand older Puppeteer-era deps).
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lib/ts/test/build.xml | Updates downloaded QUnit asset versions/URLs used by the TS test build. |
| lib/ts/package.json | Upgrades grunt-contrib-qunit and adds an override to select Puppeteer 25.8.0. |
| lib/ts/package-lock.json | Updates the resolved dependency graph to match the new dev dependency set (removing extract-zip). |
Files not reviewed (1)
- lib/ts/package-lock.json: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+40
to
+42
| "grunt-contrib-qunit": { | ||
| "puppeteer": "25.8.0" | ||
| }, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TypeScript browser test tooling still pulled extract-zip through grunt-contrib-qunit 3.1.0 and Puppeteer 1.x.
This updates grunt-contrib-qunit to 10.2.0, selects Puppeteer 25.8.0 for its browser runner, and removes extract-zip from the development dependency tree. It also aligns the downloaded QUnit assets to 2.26.0, whose event API is expected by the current Grunt plugin.
Puppeteer 25 requires Node.js 22.12 or newer for this development-only test path.
[skip ci]anywhere in the commit message to free up build resources.