Skip to content

Replace deprecated OpenSSL API ASN1_STRING_data() - #3738

Open
brad0 wants to merge 1 commit into
apache:masterfrom
brad0:cpp_src_thrift_transport_TSSLSocket
Open

Replace deprecated OpenSSL API ASN1_STRING_data()#3738
brad0 wants to merge 1 commit into
apache:masterfrom
brad0:cpp_src_thrift_transport_TSSLSocket

Conversation

@brad0

@brad0 brad0 commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

ASN1_STRING_data() has been deprecated since OpenSSL 1.1.0. Replace
with ASN1_STRING_get0_data(). ASN1_STRING_data() has been removed
with OpenSSL 4.

  • Did you create an Apache Jira ticket? (Request account here, not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

ASN1_STRING_data() has been deprecated since OpenSSL 1.1.0. Replace
with ASN1_STRING_get0_data(). ASN1_STRING_data() has been removed
with OpenSSL 4.
@mergeable mergeable Bot added the c++ Pull requests that update C++ code label Aug 23, 2026
@loqs

loqs commented Aug 24, 2026

Copy link
Copy Markdown

Will you be doing the other conversions required for OpenSLL 4.0?:

  • Replace deprecated SSLv23_method/SSLv3_method/TLSv*_method with TLS_method().
  • Use SSL_CTX_set_min/max_proto_version instead of per-version method functions.
  • Guard use of or remove ERR_remove_state().
  • Add const now required by some X509 APIs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Pull requests that update C++ code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants