Skip to content

fix(ci): stop cancelling in-progress Backport Approvals runs #8523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mengw15 wants to merge 3 commits into
base: main
Choose a base branch
from
+9 −1
Open

fix(ci): stop cancelling in-progress Backport Approvals runs #8523

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8b93fd0
fix(ci): stop cancelling in-progress Backport Approvals runs
mengw15 Sep 12, 2026
32ac293
Merge branch 'main' into fix/backport-approval-check-cancel-race
mengw15 Sep 12, 2026
428dfb4
fix(ci): narrow the concurrency comment to the guarantee that holds
mengw15 Sep 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion .github/workflows/backport-approval-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,15 @@ permissions:

concurrency:
group: backport-approvals-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true
# Never cancel the run in progress: this is a required status check, and GitHub
# takes the LATEST check run with this name -- a cancelled in-progress run's
# terminal state can land after a newer run's success (the job is seconds long)
# and block the merge as a failed required check. GitHub still keeps at most one
# pending run per group and replaces it on a newer event, but a replaced pending
# run is cancelled before its successor even starts, so the last word on the
# commit is always a real verdict. A skipped intermediate event loses nothing:
# the job reads the live labels and reviews at run time, not the event payload.
cancel-in-progress: false

jobs:
backport-approvals:
Expand Down
Loading