feat(workflow-form): embed the read-only workflow preview - #8429
Draft
yangzhang75 wants to merge 2 commits into
Draft
feat(workflow-form): embed the read-only workflow preview#8429yangzhang75 wants to merge 2 commits into
yangzhang75 wants to merge 2 commits into
Conversation
Contributor
Automated Reviewer SuggestionsBased on the
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #8429 +/- ##
============================================
- Coverage 94.03% 94.03% -0.01%
+ Complexity 4821 4820 -1
============================================
Files 1207 1207
Lines 49109 49202 +93
Branches 5963 5975 +12
============================================
+ Hits 46180 46266 +86
- Misses 1461 1464 +3
- Partials 1468 1472 +4
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
On top of the page shell: the title bar's workflow name (renamable in place, exactly as on the operator canvas), its 'Saved at ...' state, and the debounced save both views share -- so an edit made in the form is not lost on the canvas, and vice versa. A save fills in a position for every operator and reports a failure rather than losing it silently. The read-only preview, inputs, running and results are added by later PRs. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Add the collapsible workflow preview to the Form View frame, and the read-only support the embedded editor needs: a structureLocked mode on the shared workflow editor that locks the graph shape (dragging, linking, deleting) without touching the modification lock the property panel rides on, suppresses the shared cursor, and a container ResizeObserver so the paper draws correctly wherever it is mounted. The preview builds that editor and its mini-map the first time the reader opens the strip. With the flag on the form renders for any workflow, so the preview shows the graph read-only regardless of the workflow's default view. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
yangzhang75
force-pushed
the
formview-pr8
branch
from
September 4, 2026 20:49
7a61e73 to
6b9d453
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Building on the title-bar frame (#8391), this PR adds the collapsible read-only workflow preview to the Form View, and the read-only support the embedded editor needs (parent issue #8011). Frontend only.
structureLockedon the sharedworkflow-editor: a mode that locks the graph shape (dragging, linking, deleting) without touching the workflow-modification lock the property panel rides on, and suppresses the shared cursor so a read-only view never broadcasts one. It defaults tofalse, so the operator canvas is unchanged. A containerResizeObserverkeeps the paper sized to its own container (the strip toggles it viadisplay:none, which the window-resize handler never hears), and operators already in the graph when this late-mounting editor appears are repainted so a completed run's colours are not missing.The inputs, running and results are added on top of this by later PRs.
Screenshot
The workflow preview open on the read-only page (the "Workflow" strip expanded to the embedded editor + mini-map):

Any related issues, documentation, discussions?
Part of the Form View feature (parent issue #8011); stacked on #8391 (title bar) and #8376 (page shell). Until those merge, this PR's diff includes their commits as well.
How was this PR tested?
Unit tests (vitest):
workflow-form.component.spec.ts(direct construction) andworkflow-form.rendered.spec.ts(TestBed-rendered template) cover the strip's open/build/close/walk-away behaviour and the rendered bar; the sharedworkflow-editor.component.spec.ts(106 tests) is unchanged and green, confirming thestructureLockedsplit leaves the canvas untouched. The page component is at 100% of its TypeScript, and every line added toworkflow-editoris covered. Three template lines are not exercised: the<texera-workflow-editor>and<texera-mini-map>embed behind*ngIf, which need a real JointJS paper jsdom cannot provide (the editor's own paper code is v8-ignored for the same reason).ng buildis clean.Was this PR authored or co-authored using generative AI tooling?
Yes. Co-authored with Claude (Anthropic), reviewed line by line by the author before submission.