Skip to content

fix(workflow): return 404 for missing workflow type #8398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VuMartin wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(workflow): return 404 for missing workflow type #8398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6a1cd9d
return 404 for missing workflow type
VuMartin Sep 4, 2026
3608088
cover missing workflow type
VuMartin Sep 4, 2026
f725f38
fix test name to throw
VuMartin Sep 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .../main/scala/org/apache/texera/web/resource/dashboard/user/workflow/WorkflowResource.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -848,6 +848,9 @@ class WorkflowResource extends LazyLogging {
@Path("/type/{wid}")
def getWorkflowType(@PathParam("wid") wid: Integer): String = {
val workflow: Workflow = workflowDao.fetchOneByWid(wid)
if (workflow == null) {
throw new NotFoundException(s"Workflow with id $wid not found")
Comment thread
Yicong-Huang marked this conversation as resolved.
}
if (workflow.getIsPublic) {
"Public"
} else {
Expand Down
6 changes: 6 additions & 0 deletions ...r/src/test/scala/org/apache/texera/web/resource/dashboard/file/WorkflowResourceSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -947,6 +947,12 @@ class WorkflowResourceSpec
assert(sizes.get(wid) == content.length)
}

it should "throw NotFoundException for a missing workflow type" in {
assertThrows[NotFoundException] {
workflowResource.getWorkflowType(Integer.valueOf(2147483647))
}
}

"WorkflowResource.getSize" should "return an empty map for a null or empty id list" in {
assert(workflowResource.getSize(null).isEmpty)
assert(workflowResource.getSize(Collections.emptyList()).isEmpty)
Expand Down
Loading