Skip to content

chore(amber): remove the commented-out MockKillWorkerResource #8396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aglinxinyuan wants to merge 1 commit into
base: main
Choose a base branch
from
+0 −40
Open

chore(amber): remove the commented-out MockKillWorkerResource #8396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion amber/src/main/scala/org/apache/texera/web/TexeraWebApplication.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,6 @@ class TexeraWebApplication
environment.servlets.setSessionHandler(new SessionHandler)

@Yicong-Huang Yicong-Huang Sep 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must fix:

"never-registered" is refuted by git: TexeraWebApplication registered this class live from 41a8a9201 (2020-08-20) until 4a64935c3 (2021-01-30). "commented-out" is both accurate and the stronger claim, since the file defines nothing at all. Suggested: chore(amber): remove the commented-out MockKillWorkerResource. Type and scope are correct and stay.

@aglinxinyuan aglinxinyuan Sep 5, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied — the title is now chore(amber): remove the commented-out MockKillWorkerResource, and the description's opening line says what the file actually is (every non-blank line after the ASF header is a comment) instead of calling it a never-registered resource. Re-checked the live window against the diffs: 41a8a92017 registered it on 2020-08-20 and #1000 (4a64935c35) commented the registration out on 2021-01-30 — about five months registered.

Squash here takes PR_TITLE + PR_BODY (repo settings), so the corrected text is what ships; the branch commit's subject is left as is.

🤖 Addressed by Claude Code

@Yicong-Huang Yicong-Huang Sep 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must fix:

Both commits the History table attributes are wrong. 134bc9ba64 replaced the named import with a wildcard, and environment.jersey().register(classOf[MockKillWorkerResource]) is still an uncommented line in that same diff. #1394 (88ff5c840) only reindented a placeholder that #1000 (4a64935c3) had created. #1000 is the commit that actually ended this code and the table never names it. That also corrects "dead for about six years" to roughly 4.6. Issue #8393 carries the same text.

@aglinxinyuan aglinxinyuan Sep 5, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied — the History table now has two rows, Introduced by 41a8a92017 (2020-08-20, registered live) and Disabled by #1000 (4a64935c35, 2021-01-30), which commented out the registration line and the whole file body in the same diff. 134bc9ba64 and #1394 are out of the table — re-read both diffs, and neither ended the code: the first replaces the named import with edu.uci.ics.texera.web.resource._ while environment.jersey().register(classOf[MockKillWorkerResource]) sits unchanged as a context line, and the second — like #1251 (933b5775e8) before it — only re-indents the already-commented line. Issue #8393's title and body carry the same corrections.

One number I land differently: 2021-01-30 to today is about 5.6 years (five years to 2026-01-30, plus seven months), not 4.6 — so the text now says "about five and a half years". That also costs it the "longest-standing item in this series" line, which is gone from the body: #7451's ElidableStatement lost its last caller on 2021-01-11, and #8333's PropertyNameConstants was never adopted after 2020-08-20.

🤖 Addressed by Claude Code


environment.jersey.register(classOf[SystemMetadataResource])
// environment.jersey().register(classOf[MockKillWorkerResource])

environment.jersey.register(classOf[HealthCheckResource])

Expand Down
39 changes: 0 additions & 39 deletions amber/src/main/scala/org/apache/texera/web/resource/MockKillWorkerResource.scala
View file
Open in desktop

This file was deleted.

Loading