feat(operator): export the estimators and the Hugging Face models - #8368
Draft
kz930 wants to merge 1 commit into
Draft
feat(operator): export the estimators and the Hugging Face models#8368kz930 wants to merge 1 commit into
kz930 wants to merge 1 commit into
Conversation
The scikit-learn estimators are fitted on one port and score on the other, so the script holds both frames and narrows each by the same rule: a fit and a score taken on different columns would compare two different models. The four Hugging Face models declare the column types they take, and the iris regression keeps the row when a petal measurement is empty rather than ending the run on it. Sklearn Prediction and Sklearn Testing are reported as unverifiable rather than exported blind: each consumes a fitted model on an input port, and a fixture written from the JVM cannot carry a live Python object. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
Automated Reviewer SuggestionsBased on the
|
This was referenced Sep 2, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8368 +/- ##
============================================
- Coverage 94.11% 94.11% -0.01%
+ Complexity 4811 4802 -9
============================================
Files 1197 1197
Lines 48813 48804 -9
Branches 5906 5906
============================================
- Hits 45939 45930 -9
Misses 1420 1420
Partials 1454 1454
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
📊 Arrow Flight E2E bench(no arrow-flight-e2e.csv in artifact) |
carloea2
suggested changes
Sep 4, 2026
carloea2
left a comment
carloea2
left a comment
Contributor
There was a problem hiding this comment.
Sklearn Testing drops rows with missing values in the engine path, but the standalone code uses all rows. Missing values can make the script fail or produce different scores. Please apply the same filtering before building X and Y, and add a parity test with a missing row.
kz930
marked this pull request as draft
September 4, 2026 17:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
The scikit-learn estimators are fitted on one port and score on the other, so
the script holds both frames and narrows each by the same rule: a fit and a
score taken on different columns would compare two different models.
The four Hugging Face models declare the column types they take, and the iris
regression keeps the row when a petal measurement is empty rather than ending
the run on it.
Sklearn Prediction and Sklearn Testing are reported as unverifiable rather
than exported blind: each consumes a fitted model on an input port, and a
fixture written from the JVM cannot carry a live Python object.
Any related issues, documentation, discussions?
Part of #8325, 16 of 21; that issue lists the set in order. It needs #8327 for the trait, so it does not compile until that lands, and the rows these operators add to the verification runner follow with the harness rather than as whole new files here.
Closes #8316, closes #8056.
Closes #8422, the task this change is the whole of.
How was this PR tested?
Each operator asserts the block it emits in its own spec. Once the harness lands, each is also run through the engine and through its generated script, on every configuration its schema offers, and the two answers compared.
Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 5)