refactor(core): remove unreachable null guards in Attribute.equals - #8267
refactor(core): remove unreachable null guards in Attribute.equals#8267Alwaysgaurav1 wants to merge 3 commits into
Conversation
…equals Remove unreachable null checks on this.attributeName and this.attributeType in Attribute.equals(), since the constructor enforces non-null for both fields via checkNotNull. This also removes the latent bug in the second guard where attributeName was ignored during comparison. Closes apache#8149
|
👋 Thanks for your first contribution to Texera, @Alwaysgaurav1! If you're looking for a good place to start, browse issues labeled You can drive common housekeeping yourself by commenting one of these commands on its own line:
Each command must match exactly: |
|
👋 Thanks for opening this pull request, @Alwaysgaurav1! It looks like the pull request description doesn't quite follow our template yet:
Filling out the template helps reviewers understand and triage your contribution faster. Please edit the description to complete it. This message will disappear automatically once the template is followed. You can find the template prompts by editing the description, or see CONTRIBUTING.md for the full contribution flow. |
Backport auto-label reportThis
|
Automated Reviewer SuggestionsBased on the
|
|
Thanks for the PR. Please follow the pull request template. Also, since this is not a bug fix, you may want to rename the PR title to use refactor. Temporarily marked it as a draft. Please feel free to mark it as ready for review once the PR is ready. |
|
Thanks for the guidance, @xuang7 |
The description is still incomplete. You may refer to other PRs as examples. |
What changes were proposed in this PR?
In
Attribute.java(common/workflow-core/src/main/scala/org/apache/texera/amber/core/tuple/Attribute.java),Attribute.equals()contained redundant/unreachable null guards: