[SPARK-58964][ML] Consolidate vector and matrix UDT column conversion - #58241
Open
zhengruifeng wants to merge 7 commits into
Open
[SPARK-58964][ML] Consolidate vector and matrix UDT column conversion#58241zhengruifeng wants to merge 7 commits into
zhengruifeng wants to merge 7 commits into
Conversation
zhengruifeng
marked this pull request as draft
August 24, 2026 09:23
zhengruifeng
marked this pull request as ready for review
August 24, 2026 12:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR consolidates UDT column selection in these
MLUtilsconversion helpers:MLUtils.convertVectorColumnsToMLMLUtils.convertVectorColumnsFromMLMLUtils.convertMatrixColumnsToMLMLUtils.convertMatrixColumnsFromMLWhen columns are not explicitly specified, each helper preserves the previous automatic selection
behavior:
ToMLhelpers select only oldmllibUDT columns, andFromMLhelpers select only newmlUDT columns. For explicit columns, the helpers validate that the named columns exist and relyon the existing
wrap_udt(unwrap_udt(...))expression analysis to reject non-UDT inputs.Converted columns are replaced with the metadata-preserving
withColumnsoverload instead ofrebuilding the whole projection manually.
Why are the changes needed?
After vector and matrix conversion moved to
wrap_udt/unwrap_udt, the explicit-column paths nolonger need separate source-type and target-type branches when deciding whether a column can be
converted.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Ran:
Also ran:
git diff --checkWas this patch authored or co-authored using generative AI tooling?
Generated-by: OpenAI Codex