[MINOR][ML] Simplify SummarizerBuffer branching - #58236
Draft
zhengruifeng wants to merge 2 commits into
Draft
Conversation
HyukjinKwon
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR simplifies
SummarizerBufferby precomputing requested metric and compute metric flags once, moving one-time array initialization into a helper, and splitting merge handling into empty-summary guard clauses plus focused non-empty merge/copy helpers.The change preserves the existing aggregate state layout and public behavior.
Why are the changes needed?
SummarizerBufferhas several hot paths with repeatedSeq.containschecks and nested null/empty branches. The refactor makes the control flow easier to read and removes repeated metric membership checks while keeping the same metric computations.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Ran: