[SPARK-58948][SQL] Deduplicate nulls-buffer creation in columnar decompressors - #58228
Closed
uros-b wants to merge 3 commits into
Closed
[SPARK-58948][SQL] Deduplicate nulls-buffer creation in columnar decompressors#58228uros-b wants to merge 3 commits into
uros-b wants to merge 3 commits into
Conversation
uros-b
commented
Aug 23, 2026
uros-b
left a comment
uros-b
left a comment
Member
Author
There was a problem hiding this comment.
Thank you for review @dongjoon-hyun
Member
Author
|
Thank you @dongjoon-hyun! |
uros-b
added a commit
that referenced
this pull request
Aug 24, 2026
…mpressors ### What changes were proposed in this pull request? Each columnar decompressor repeats the same two-line idiom to build the "nulls buffer" it reads null-tracking state from: ```scala val nullsBuffer = buffer.duplicate().order(ByteOrder.nativeOrder()) nullsBuffer.rewind() ``` This adds a `createNullsBuffer(buffer: ByteBuffer)` helper to the `CompressionScheme` companion object (alongside the existing `columnHeaderSize` helper) and routes the six call sites through it (`PassThrough`, `RunLengthEncoding`, `DictionaryEncoding`, `BooleanBitSet`, `IntDelta`, `LongDelta`). The subsequent `nullCount` / `nextNullIndex` reads stay inline, since the `nextNullIndex` sentinel legitimately differs (`-1`, and `capacity` for `PassThrough`). ### Why are the changes needed? The idiom was duplicated across all six decoders. Naming it once removes the duplication and gives a single home for the "duplicate, set native order, rewind" convention. It also normalizes the `LongDelta` site, which called `rewind` without parentheses. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing columnar compression tests. `createNullsBuffer` returns exactly the previously-inlined expression, so decompression behavior is unchanged. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Code (Opus 4.8) Closes #58228 from uros-b/helper-compressionschemes-nullindex. Authored-by: Uros <221401595+uros-b@users.noreply.github.com> Signed-off-by: Uros Bojanic <221401595+uros-b@users.noreply.github.com> (cherry picked from commit 7e875f1) Signed-off-by: Uros Bojanic <221401595+uros-b@users.noreply.github.com>
uros-b
added a commit
that referenced
this pull request
Aug 24, 2026
…mpressors ### What changes were proposed in this pull request? Each columnar decompressor repeats the same two-line idiom to build the "nulls buffer" it reads null-tracking state from: ```scala val nullsBuffer = buffer.duplicate().order(ByteOrder.nativeOrder()) nullsBuffer.rewind() ``` This adds a `createNullsBuffer(buffer: ByteBuffer)` helper to the `CompressionScheme` companion object (alongside the existing `columnHeaderSize` helper) and routes the six call sites through it (`PassThrough`, `RunLengthEncoding`, `DictionaryEncoding`, `BooleanBitSet`, `IntDelta`, `LongDelta`). The subsequent `nullCount` / `nextNullIndex` reads stay inline, since the `nextNullIndex` sentinel legitimately differs (`-1`, and `capacity` for `PassThrough`). ### Why are the changes needed? The idiom was duplicated across all six decoders. Naming it once removes the duplication and gives a single home for the "duplicate, set native order, rewind" convention. It also normalizes the `LongDelta` site, which called `rewind` without parentheses. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing columnar compression tests. `createNullsBuffer` returns exactly the previously-inlined expression, so decompression behavior is unchanged. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Code (Opus 4.8) Closes #58228 from uros-b/helper-compressionschemes-nullindex. Authored-by: Uros <221401595+uros-b@users.noreply.github.com> Signed-off-by: Uros Bojanic <221401595+uros-b@users.noreply.github.com> (cherry picked from commit 7e875f1) Signed-off-by: Uros Bojanic <221401595+uros-b@users.noreply.github.com>
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Each columnar decompressor repeats the same two-line idiom to build the "nulls buffer" it reads null-tracking state from:
This adds a
createNullsBuffer(buffer: ByteBuffer)helper to theCompressionSchemecompanion object (alongside the existingcolumnHeaderSizehelper) and routes the six call sites through it (PassThrough,RunLengthEncoding,DictionaryEncoding,BooleanBitSet,IntDelta,LongDelta). The subsequentnullCount/nextNullIndexreads stay inline, since thenextNullIndexsentinel legitimately differs (-1, andcapacityforPassThrough).Why are the changes needed?
The idiom was duplicated across all six decoders. Naming it once removes the duplication and gives a single home for the "duplicate, set native order, rewind" convention. It also normalizes the
LongDeltasite, which calledrewindwithout parentheses.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing columnar compression tests.
createNullsBufferreturns exactly the previously-inlined expression, so decompression behavior is unchanged.Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.8)