[SPARK-58021][CONNECT][FOLLOWUP] Strip launcher-owned binding address from seed configuration - #58088
Closed
cloud-fan wants to merge 1 commit into
Closed
[SPARK-58021][CONNECT][FOLLOWUP] Strip launcher-owned binding address from seed configuration#58088cloud-fan wants to merge 1 commit into
cloud-fan wants to merge 1 commit into
Conversation
… from seed configuration
Contributor
Author
uros-b
approved these changes
Aug 19, 2026
Member
|
Thank you @cloud-fan! |
Contributor
Author
|
thanks for the review, merging to master/4.x |
cloud-fan
added a commit
that referenced
this pull request
Aug 24, 2026
… from seed configuration ### What changes were proposed in this pull request? Followup to #57684. Add `spark.connect.grpc.binding.address` to the settings removed by `_strip_launcher_conf` before writing local Connect server seed properties. ### Why are the changes needed? The local server launcher sets the binding address explicitly on its command line. Removing the same setting from seed properties keeps all launcher-owned settings centralized and avoids carrying a competing value in the generated properties file. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? No new test was added because this completes the existing launcher-owned configuration allowlist; the behavior is covered by the existing seed-configuration tests from the original change. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: OpenAI Codex (GPT-5) Closes #58088 from cloud-fan/SPARK-58021-followup-245101. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit 7b2c532) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Followup to #57684.
Add
spark.connect.grpc.binding.addressto the settings removed by_strip_launcher_confbefore writing local Connect server seed properties.Why are the changes needed?
The local server launcher sets the binding address explicitly on its command line. Removing the
same setting from seed properties keeps all launcher-owned settings centralized and avoids carrying
a competing value in the generated properties file.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
No new test was added because this completes the existing launcher-owned configuration allowlist;
the behavior is covered by the existing seed-configuration tests from the original change.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: OpenAI Codex (GPT-5)