Use makePath helper consistently across codebase#4636
Open
epugh wants to merge 2 commits into
Open
Conversation
github-actions
Bot
added
client:solrj
cat:cloud
cat:cli
cat:api
cat:schema
cat:packagemanager
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is spun off a comment that @dsmiley made about some flaky tests: https://issues.apache.org/jira/browse/SOLR-18233?focusedCommentId=18094837&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-18094837
Solution
I looked over, with claude help, the code base looking for all the places that were not using the
zkClient.makePathhelper, and updated to use it. I also tweaked the javadcos, and then in hte one place we do NOT want to use it, made a explicit call out.Tests
Rerun existing tests. i don't know how to "beast" a bats test, but hopefully we'll see it.