Skip to content

Fix the consumer race in spring-kafka-1.3.x and 2.2.x scenarios #844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wu-sheng wants to merge 2 commits into
base: main
Choose a base branch
from
+42 −2
Open

Fix the consumer race in spring-kafka-1.3.x and 2.2.x scenarios #844

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c4ff87
Fix the consumer race in spring-kafka-1.3.x and 2.2.x scenarios
wu-sheng Oct 31, 2026
0bd593b
Merge branch 'main' into fix-spring-kafka-scenario-race
wu-sheng Oct 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion ...main/java/test/apache/skywalking/apm/testcase/spring/kafka/controller/CaseController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,10 @@
import okhttp3.Request;
import okhttp3.Response;
import org.apache.kafka.clients.consumer.ConsumerConfig;
import org.apache.kafka.clients.consumer.ConsumerRebalanceListener;
import org.apache.kafka.clients.consumer.ConsumerRecord;
import org.apache.kafka.clients.producer.ProducerConfig;
import org.apache.kafka.common.TopicPartition;
import org.apache.kafka.common.serialization.Deserializer;
import org.apache.kafka.common.serialization.StringDeserializer;
import org.apache.kafka.common.serialization.StringSerializer;
Expand All @@ -43,6 +45,7 @@

import javax.annotation.PostConstruct;
import java.io.IOException;
import java.util.Collection;
import java.util.HashMap;
import java.util.Map;
import java.util.concurrent.CountDownLatch;
Expand All @@ -61,6 +64,7 @@ public class CaseController {

private CountDownLatch latch = new CountDownLatch(1);
private String helloWorld = "helloWorld";
private volatile boolean partitionsAssigned = false;

@PostConstruct
private void setUp() {
Expand Down Expand Up @@ -91,6 +95,19 @@ private void setUpConsumer() {
Deserializer<String> stringDeserializer = new StringDeserializer();
DefaultKafkaConsumerFactory<String, String> factory = new DefaultKafkaConsumerFactory(configs, stringDeserializer, stringDeserializer);
ContainerProperties props = new ContainerProperties(topicName);
// The consumer starts from the latest offset, so the case must not send before partitions are assigned.
props.setConsumerRebalanceListener(new ConsumerRebalanceListener() {
@Override
public void onPartitionsRevoked(Collection<TopicPartition> partitions) {
}

@Override
public void onPartitionsAssigned(Collection<TopicPartition> partitions) {
if (!partitions.isEmpty()) {
partitionsAssigned = true;
}
}
});
props.setMessageListener(new AcknowledgingMessageListener<String, String>() {
@Override
public void onMessage(ConsumerRecord<String, String> data, Acknowledgment acknowledgment) {
Expand Down Expand Up @@ -131,7 +148,10 @@ public String springKafkaConsumerPing() {
@RequestMapping("/healthCheck")
@ResponseBody
public String healthCheck() {
return SUCCESS;
if (partitionsAssigned) {
return SUCCESS;
}
throw new RuntimeException("kafka consumer partitions not assigned");
}
}

22 changes: 21 additions & 1 deletion ...main/java/test/apache/skywalking/apm/testcase/spring/kafka/controller/CaseController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,10 @@
import okhttp3.Request;
import okhttp3.Response;
import org.apache.kafka.clients.consumer.ConsumerConfig;
import org.apache.kafka.clients.consumer.ConsumerRebalanceListener;
import org.apache.kafka.clients.consumer.ConsumerRecord;
import org.apache.kafka.clients.producer.ProducerConfig;
import org.apache.kafka.common.TopicPartition;
import org.apache.kafka.common.serialization.Deserializer;
import org.apache.kafka.common.serialization.StringDeserializer;
import org.apache.kafka.common.serialization.StringSerializer;
Expand All @@ -42,6 +44,7 @@

import javax.annotation.PostConstruct;
import java.io.IOException;
import java.util.Collection;
import java.util.HashMap;
import java.util.Map;
import java.util.concurrent.CountDownLatch;
Expand All @@ -60,6 +63,7 @@ public class CaseController {

private CountDownLatch latch = new CountDownLatch(1);
private String helloWorld = "helloWorld";
private volatile boolean partitionsAssigned = false;

@PostConstruct
private void setUp() {
Expand Down Expand Up @@ -90,6 +94,19 @@ private void setUpConsumer() {
Deserializer<String> stringDeserializer = new StringDeserializer();
DefaultKafkaConsumerFactory<String, String> factory = new DefaultKafkaConsumerFactory(configs, stringDeserializer, stringDeserializer);
ContainerProperties props = new ContainerProperties(topicName);
// The consumer starts from the latest offset, so the case must not send before partitions are assigned.
props.setConsumerRebalanceListener(new ConsumerRebalanceListener() {
@Override
public void onPartitionsRevoked(Collection<TopicPartition> partitions) {
}

@Override
public void onPartitionsAssigned(Collection<TopicPartition> partitions) {
if (!partitions.isEmpty()) {
partitionsAssigned = true;
}
}
});
props.setMessageListener(new AcknowledgingMessageListener<String, String>() {
@Override
public void onMessage(ConsumerRecord<String, String> data, Acknowledgment acknowledgment) {
Expand Down Expand Up @@ -130,7 +147,10 @@ public String springKafkaConsumerPing() {
@RequestMapping("/healthCheck")
@ResponseBody
public String healthCheck() {
return SUCCESS;
if (partitionsAssigned) {
return SUCCESS;
}
throw new RuntimeException("kafka consumer partitions not assigned");
}
}

Loading