RANGER-5794: Atlas permissions reappear in tag policies when enableTagBasedPolicies is disabled - #1225
Open
RakeshGuptaDev wants to merge 1 commit into
Open
RANGER-5794: Atlas permissions reappear in tag policies when enableTagBasedPolicies is disabled#1225RakeshGuptaDev wants to merge 1 commit into
RakeshGuptaDev wants to merge 1 commit into
Conversation
…gBasedPolicies is disabled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
After RANGER-4805, Atlas permissions (atlas:read, etc.) can still appear in tag policies and in x_access_type_def, especially after RANGER-3491 changed the service-definition bootstrap flow.
Cause:
The enableTagBasedPolicies check was only present in updateTagServiceDefForAccessTypes(), which is no longer called from the production code. The actual sync path (postCreate / postUpdate → updateTagServiceDefForUpdatingAccessTypes()) did not have this check, allowing Atlas permissions to be synced into the tag service-definition.
How was this patch tested?
Tested upgrade with J10063 patch; verified atlas:* absent from x_access_type_def and tag policy UI. Restarted Ranger Admin and updated Atlas service-def — Atlas permissions did not reappear.