Skip to content

RANGER-5750:Handle authorization of hbase:acl table in RangerAuthorizationCoprocessor in HBase Ranger plugin #1201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rameeshm wants to merge 1 commit into
base: master
Choose a base branch
from
+37 −5
Open

RANGER-5750:Handle authorization of hbase:acl table in RangerAuthorizationCoprocessor in HBase Ranger plugin #1201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions ...t/src/main/java/org/apache/ranger/authorization/hbase/RangerAuthorizationCoprocessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1390,7 +1390,7 @@ boolean canSkipAccessCheck(User user, final String operation, String access, fin
LOG.warn("canSkipAccessCheck: exiting{}", "Unexpeceted: User is null: access denied, not audited!");

throw new AccessDeniedException("No user associated with request (" + operation + ") for action: " + access + "on table:" + table);
} else if (isAccessForMetadataRead(access, table)) {
} else if (isAccessForMetadataRead(access, table, user)) {
LOG.debug("canSkipAccessCheck: true: metadata read access always allowed, not audited");

result = true;
Expand Down Expand Up @@ -1434,8 +1434,25 @@ boolean canSkipAccessCheck(User user, final String operation, String access, fin

/* ---- EndpointObserver implementation ---- */

boolean isAccessForMetadataRead(String access, String table) {
boolean isAccessForMetadataRead(String access, String table, User user) {
if (authUtils.isReadAccess(access) && isSpecialTable(table)) {
if (StringUtils.equals(table, "hbase:acl")) {
boolean isSystemOrSuperUser = false;
try {
User currentUser = User.getCurrent();
if (currentUser != null && user != null) {
isSystemOrSuperUser = Objects.equals(currentUser.getShortName(), user.getShortName());
}
} catch (IOException e) {
LOG.warn("Unable to obtain the current user", e);
}
if (!isSystemOrSuperUser && user != null) {
isSystemOrSuperUser = userUtils.isSuperUser(user);
}
if (!isSystemOrSuperUser) {
return false;
}
}
LOG.debug("isAccessForMetadataRead: Metadata tables read: access allowed!");

return true;
Expand Down
21 changes: 18 additions & 3 deletions ...c/test/java/org/apache/ranger/authorization/hbase/RangerAuthorizationCoprocessorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,12 +391,27 @@ public void test18_requirePermission_region_allowsOrDenies() throws Exception {
}

@Test
public void test19_isSpecialTable_and_metadataRead() {
public void test19_isSpecialTable_and_metadataRead() throws Exception {
RangerAuthorizationCoprocessor cp = new RangerAuthorizationCoprocessor();
Assertions.assertTrue(cp.isSpecialTable("hbase:meta"));
Assertions.assertFalse(cp.isSpecialTable("normal"));
Assertions.assertTrue(cp.isAccessForMetadataRead("read", "hbase:acl"));
Assertions.assertFalse(cp.isAccessForMetadataRead("write", "hbase:acl"));
Assertions.assertFalse(cp.isAccessForMetadataRead("read", "hbase:acl", null));
Assertions.assertFalse(cp.isAccessForMetadataRead("write", "hbase:acl", null));

// Test for system user bypass on hbase:acl
User systemUser = mock(User.class);
when(systemUser.getShortName()).thenReturn(User.getCurrent().getShortName());
Assertions.assertTrue(cp.isAccessForMetadataRead("read", "hbase:acl", systemUser));

// Test for super user bypass on hbase:acl
User superUser = mock(User.class);
when(superUser.getShortName()).thenReturn("some_super_user");
HbaseUserUtils userUtils = mock(HbaseUserUtils.class);
lenient().when(userUtils.isSuperUser(superUser)).thenReturn(true);
Field userUtilsField = RangerAuthorizationCoprocessor.class.getDeclaredField("userUtils");
userUtilsField.setAccessible(true);
userUtilsField.set(cp, userUtils);
Assertions.assertTrue(cp.isAccessForMetadataRead("read", "hbase:acl", superUser));
}

@Test
Expand Down