Conversation
lhotari
approved these changes
Sep 18, 2026
lhotari
left a comment
Member
There was a problem hiding this comment.
LGTM. Thanks for fixing the rollover case and adding regression coverage for both pending writes and invalid positions.
dao-jun
approved these changes
Sep 19, 2026
nodece
approved these changes
Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #26184.
Motivation
After ledger rollover, a caught-up cursor can move to
currentLedger:-1while the first write to the new ledger is still pending. SincecurrentLedgerEntriesincludes pending writes, the check introduced in #26184 can reject this valid state and causegetEstimatedSizeSinceMarkDeletePosition()to throw, potentially skipping a compaction check.The same check also incorrectly accepts nonnegative mark-delete entry IDs on an empty current ledger.
Modifications
currentLedger:-1sentinel without relying oncurrentLedgerEntries.ManagedLedgerBkTest, using real BookKeeper operations without mocks or direct internal-state mutation. Cover a pending first write during rollover and an invalid nonnegative mark-delete entry ID on an empty ledger.Verifying this change
Both new regression tests fail on the original implementation for the expected reasons. After the fix, all 9 selected tests and
quickCheckpass locally:Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes