Conversation
lhotari
reviewed
Sep 18, 2026
lhotari
reviewed
Sep 18, 2026
TomaszGaweda
force-pushed
the
move-TransactionCoordinatorClient-to-public-api
branch
from
September 19, 2026 08:41
c98de95 to
9cdbaec
Compare
lhotari
approved these changes
Sep 19, 2026
…t-to-public-api' into move-TransactionCoordinatorClient-to-public-api
dao-jun
approved these changes
Sep 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to: #26452
This PR removes of
@PrivateApiannotations from TransactionCoordinatorClient and with moves TransactionCoordinatorClient to a public API for PulsarClient.Fixes #26452
Motivation
One thing that is missing is our ability for commit or abort a transaction by ID itself. It is super useful (mandatory for exactly-once) in streaming engines, like Hazelcast Jet or Apache Flink. We (Hazelcast) track snapshot transaction IDs (including TxnID), in case of failures we want to be able to reliably commit or abort transactions in progress. Right now it's impossible to do officially.
I can do following:
and Flink was also doing this.
However, it relies on casting to implementation classes classes and using interface marked as PrivateApi.
Modifications
PrivateApiannotationsVerifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes