Conversation
Signed-off-by: Dream95 <zhou_8621@163.com>
Signed-off-by: Dream95 <zhou_8621@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26568
Main Issue: #xyz
PIP: #xyz
Motivation
CI fails in
KeySharedSubscriptionTest.resetDefaultNamespacewith:Topic has 8005 clients connected Including 8004 consumers, 0 producers, and 0 replicators.
Example: https://github.com/apache/pulsar/actions/runs/34130276934/job/101987362625
The leftover clients come from
testMessageDeliveredFromDrainingHashes. That test usedaddConsumersUntilOwnerChanged, which kept creating Key_Shared consumers until consistent hashing movedtestMessageKeyoff the original owner.With
subscriptionKeySharedConsistentHashingReplicaPoints=100and a large hash space, a randomly named consumer often does not steal that hash. The loop can create thousands of consumers (8004 in the failure). The test then cannot finish cleanup before@AfterMethod, soresetDefaultNamespacecannot delete the topic.Modifications
Replace
addConsumersUntilOwnerChangedwithaddConsumerThatTakesOverHash. It picks a consumer name (takeover-N) that will own the target hash, subscribes that one consumer, and fails if the owner did not change.findConsumerNameThatTakesHashbuilds a localConsistentHashingStickyKeyConsumerSelectorwith the live replica-point count andselector.getKeyHashRange().getEnd().Cleanup only has that extra consumer to close.
findOwnerNameusesselector.select(hash).Verifying this change
This change is already covered by existing tests, such as
KeySharedSubscriptionTest.testMessageDeliveredFromDrainingHashes.Ran that method locally 500 times. All passed.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes