You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for addressing the shared topic-permission issue during cluster-removal cleanup. The added test covers the intended scenario well. I noticed two additional cases introduced by the new asynchronous check:
checkAllowedCluster() also returns false for ordinary non-replicated namespaces, where both the effective replication clusters and allowed_clusters are empty. Normal topic deletion therefore skips authentication cleanup. The topic ACL remains in metadata and may be applied again if a topic with the same name is recreated. This path also causes the current PersistentTopicTest.testDeleteTopicDeleteOnMetadataStoreFailed CI failure, because topic.delete() succeeds after bypassing the expected permission-removal failure.
When getPoliciesAsync() completes exceptionally, the thenAccept callback is not invoked and its returned stage is ignored. deleteTopicAuthenticationFuture consequently never completes. The public deletion future can then remain pending indefinitely after the topic has been fenced, leaving the topic unavailable until external recovery.
Both cases affect deletion behavior outside the successful cluster-removal scenario covered by the new test and should be addressed before merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Env
[c1, c2]with shared metadata storeIssue
[c1]c2can not access the topic anymorec1cluster topic permission configuration was deletedModifications
fix the issue
If the box was checked, please highlight the changes