Add missing ASF license header to subscription-emulation logback-test.xml#2646
Closed
ascheman wants to merge 1 commit into
Closed
Add missing ASF license header to subscription-emulation logback-test.xml#2646ascheman wants to merge 1 commit into
ascheman wants to merge 1 commit into
Conversation
plc4j/utils/subscription-emulation/src/test/resources/logback-test.xml was the only file in the tree without a license header, failing the apache-rat check for every clean checkout of the main branch. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Author
|
Superseded by 6a72ab5 — thanks for the quick direct fix, Chris! 🙂 (Answering the commit message's question: RAT only failed from a clean checkout / |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building PLC4X from a fresh checkout of
developcurrently fails after ~30 s in the root module'sapache-rat:check:plc4j/utils/subscription-emulation/src/test/resources/logback-test.xmlis the single file without an ASF license header (RAT:Unapproved: 1).This adds the same header the sibling
logback-test.xmlfiles (modbus, eip, profinet-ng, …) carry. Verified locally:mvn -N apache-rat:check→Unapproved: 0, BUILD SUCCESS.Found while testing PLC4X against a current Maven
4.0.0-SNAPSHOT(pre-RC-6) — thanks for adopting Maven 4 so early! 🙏🤖 Generated with Claude Code