Repository navigation
Conversation
FINITE_VECTOR, as proposed in apache#624 has two shortcomings that this PR is trying to avoid: * This PR does not tie finiteness to the list/vector type but instead to the contained float. This way, we can have finite floats that aren't vectors. They are useful by themselves, so having the finiteness annotation at the type to which it applies makes this more composable. * This PR does not introduce FINITE_VECTOR as a new type that basically mimics LIST with a fixed length. Instead, the LIST type itself receives an optional fixed length field. This way, legacy readers can still read vectors and simply interpret them as lists. Also, by decoupling finiteness from fixed length and not calling it vector, we gain general fixed-size lists for *all* types, instead of having just some blessed types be able to live in fixed-size lists / vectors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FINITE_VECTOR, as proposed in #624 has two shortcomings that this PR is trying to avoid:
Also, by decoupling finiteness from fixed length and not calling it vector, we gain general fixed-size lists for all types, instead of having just some blessed types be able to live in fixed-size lists / vectors.
Rationale for this change
What changes are included in this PR?
Do these changes have PoC implementations?