[core] Read the table branch schemas when rewriting file indexes - #9468
Merged
JingsongLi merged 1 commit intoAug 30, 2026
Merged
Conversation
Contributor
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
FileIndexProcessorlooks up the schema of every file it rewrites through aSchemaManagerpinned to the main branch, while the manifest entries it processes come from the table it was given. Runningrewrite_file_indexon a branch therefore resolves the branch's schema ids under main: it reads a different schema when both branches happen to have that id, and fails withFileNotFoundException: .../schema/schema-Nwhen main never had it.Tests
FileIndexProcessorTest: a branch whose schema id exists only on the branch is processed successfully; without the change the lookup throws.