fix(vortex): reject columns the writer cannot convert instead of panicking - #878
Merged
JingsongLi merged 1 commit intoSep 22, 2026
Conversation
…cking VortexFormatWriter::new passed the Arrow schema to DType::from_arrow, whose conversion ends in unimplemented!() for a type it has no arm for. Arrow Map has no arm, and that is what paimon_type_to_arrow builds for both MAP and MULTISET, so a vortex table with either column aborted the process at writer construction rather than returning an error. Screen the schema first and return Error::Unsupported naming the column, matching the per-format validator the mosaic reader already uses. The walk descends exactly the containers DType::from_arrow descends into, so a Map nested in a ROW is caught too.
Contributor
|
Reviewed head 94a6ac6. Requirement fit: SUPPORTED; implementation: CLEAN. I traced Paimon MAP/MULTISET conversion to Arrow Map and the Vortex 0.75 |
JingsongLi
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VortexFormatWriter::newhanded the Arrow schema straight toDType::from_arrow, which ends inunimplemented!()for any Arrow type it has no arm for.Mapis one of those, andpaimon_type_to_arrowbuilds aMapfor both MAP and MULTISET — so writing a vortex table with either column aborted the process at writer construction instead of returning an error. Reproduced throughcreate_table->new_write()->write_arrow_batch.Screen the schema before the conversion and return
Error::Unsupportednaming the column, followingvalidate_mosaic_schema.The check is on the Arrow schema, not
write_fields:kv_file_writerandpostpone_file_writerboth passwrite_fields: None, so aDataField-based check would silently skip the primary-key write path.