fix: canonicalize floating-point NaN values - #255
Merged
Conversation
zjw1111
marked this pull request as draft
August 27, 2026 11:33
zjw1111
marked this pull request as ready for review
August 28, 2026 02:48
2 tasks
lxy-9602
reviewed
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #256
Canonicalize floating-point NaN payloads anywhere Java-compatible equality, hashing, or binary output requires a single representation.
This change centralizes float/double canonical bit conversion and applies it to:
Tests
pre-commit run --files <all changed files>git diff --check-Werror.MathTest.FloatingPointNaNCanonicalizationFastHashTest.TestNaNCompatibleWithJavaLiteralTest.*HiveBucketFunctionTest.TestFloatNaNCanonicalizationCompatibleWithJavaHiveBucketFunctionTest.TestDoubleNaNCanonicalizationCompatibleWithJavaGenericVariantTest.CanonicalizesFloatingPointNaNKeySerializerTest.CanonicalizesFloatingPointNaNGlobalIndexResultTest.TestSerializeCanonicalizesNaNScoreIndexedSplitTest.TestSerializeCanonicalizesNaNScoreAPI and Format
No public API signature or protocol changes. Non-canonical NaN payloads are now written using the canonical Java-compatible NaN representation; existing canonical values and all non-NaN values are unchanged.
Documentation
No user-facing documentation changes.
Generative AI tooling
Generated-by: OpenAI Codex (GPT-5).