fix(compaction): persist keys in lookup SST files while first-row merge function - #250
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #251
First-row lookup uses
LookupLevels<bool>because it only needs to determine whether a primary key already exists.The previous implementation special-cased
boolby creating and immediately closing the lookup writer. This produced a valid but empty SST file. As a result, a compaction could incorrectly retain a newer row even though the first row for that key already existed.This change:
bool-specific empty SST shortcut;Tests
Added
LookupMergeTreeCompactRewriterTest.TestFirstRowLooksUpExistingKeys, covering:key=1in L2;key=1andkey=2in L0;key=2.API and Format
No public API or protocol changes.
Documentation
No documentation changes are required.
Generative AI tooling
Generated-by: Codex (GPT-5)