Repository navigation
HDDS-17596. Test OM read-path datanode sorting through KeyManager#listStatus - #11850
Open
rajeshkumarchandolu wants to merge 1 commit into
Open
rajeshkumarchandolu wants to merge 1 commit into
rajeshkumarchandolu wants to merge 1 commit into
Conversation
Member
|
Hi @rajeshkumarchandolu Please raise PR with proper Jira and follow the guidline |
priyeshkaratha
marked this pull request as draft
October 30, 2026 05:05
rajeshkumarchandolu
changed the title
rajeshkumarchandolu
force-pushed
the
om-sort-datanodes-listStatus
branch
from
October 30, 2026 09:30
8a9d98d to
67606c5
Compare
rajeshkumarchandolu
marked this pull request as ready for review
November 3, 2026 06:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
TestOMSortDatanodesread-path sorting tests now go throughKeyManager#listStatuswithsortDatanodesInPipelineenabled, instead of callingKeyManagerImpl#sortDatanodes(List, String)directly. This also covers the pipeline refresh from SCM before sorting.KeyManagerImpl#sortDatanodes(List, String)is now private. It was public only for this test.These changes are needed for the tracing proxies in OM (HDDS-17586). The key manager will be created as a tracing proxy, so that every key manager call gets its own span:
A tracing proxy implements only the
KeyManagerinterface, so a test can't reach methods that exist only onKeyManagerImpl. Instead of adding the sorting helper to the interface just for a test, the test now uses the public read API. This PR doesn't add any tracing itself, and there is no functional change.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-17596
How was this patch tested?
TestOMSortDatanodes: the 3 rewritten read-path tests and the 3 existing write-path tests.build-branchsucceeded on fork branchom-sort-datanodes-listStatus(commit8a9d98dd2d): https://github.com/rajeshkumarchandolu/ozone/actions/runs/40860344967