Repository navigation
HDDS-17595. Use the KeyManager interface instead of KeyManagerImpl casts - #11849
Draft
rajeshkumarchandolu wants to merge 1 commit into
Draft
rajeshkumarchandolu wants to merge 1 commit into
rajeshkumarchandolu wants to merge 1 commit into
Conversation
Member
|
Hi @rajeshkumarchandolu Please raise PR with proper Jira and follow the guidline |
priyeshkaratha
marked this pull request as draft
October 30, 2026 05:05
rajeshkumarchandolu
force-pushed
the
om-keymanager-interface
branch
from
October 30, 2026 09:30
2c37000 to
15e67d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
KeyManager#restartSnapshotSstFilteringService, and use it inOzoneManager#reconfOzoneSnapshotSSTFilteringServiceIntervalin place of threeKeyManagerImplcasts.KeyManager,VolumeManagerandBucketManagerinterfaces in tests instead of the implementation classes.These changes are needed for the tracing proxies in OM (HDDS-17586). The key manager will be created as a tracing proxy, so that every key manager call gets its own span, for example
KeyManagerImpl.listStatus:A tracing proxy is a JDK dynamic proxy and implements only the
KeyManagerinterface, so a cast toKeyManagerImplwould fail with aClassCastException. This PR doesn't add any tracing itself, and there is no functional change.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-17595
How was this patch tested?
TestKeyManagerUnit,TestKeyManagerImpl, andTestOzoneIntegrationNonHAincludingTestOmReconfiguration.build-branchsucceeded on fork branchom-keymanager-interface(commit2c37000906): https://github.com/rajeshkumarchandolu/ozone/actions/runs/40860345737