Repository navigation
HDDS-17441. Interrupted short-circuit GetBlock fails with NPE and leaves the received block file stream open in XceiverClientShortCircuit - #11835
Merged
Conversation
Contributor
Author
|
@ChenSammi this is ready for review |
ChenSammi
approved these changes
Oct 29, 2026
ChenSammi
left a comment
ChenSammi
left a comment
Contributor
There was a problem hiding this comment.
Thanks @Gargi-jais11 , LGTM.
Gargi-jais11
marked this pull request as ready for review
October 29, 2026 11:12
Contributor
Author
|
Thanks @ChenSammi for reviewing the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
There are two problems in
XceiverClientShortCircuitwhen a caller gives up on a short-circuit GetBlock:Objects.requireNonNull(ioException)then throws a NPE, which skips the gRPC fallback in BlockInputStream.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-17441
How was this patch tested?
Added
TestXceiverServerDomainSocket#testClientReleasesStreamOfAbandonedRequest