Repository navigation
Conversation
Subtract only healthy IN_SERVICE targets from the healthy datanode count when checking decommission and maintenance requests. Keep checking containers on STALE and DEAD targets against the required node count. Co-authored-by: Codex (GPT-6)
F64116045
marked this pull request as ready for review
October 28, 2026 04:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Before accepting a decommission or maintenance request, SCM checks whether enough healthy datanodes will remain.
It subtracts all
IN_SERVICEtargets, includingSTALEandDEADtargets that weren't included in the healthy count.For example, with three healthy datanodes and one
STALEtarget, the check calculates 3 - 1 = 2.If the target holds a container requiring three replicas, the request is rejected even though all three healthy datanodes remain available.
This PR changes both checks to subtract only targets that are
IN_SERVICEandHEALTHY.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-17511
How was this patch tested?
Added new unit tests:
each test uses a
STALEorDEADtarget. It checks that the request is rejected with too few healthy datanodes, adds one healthy datanode to meet the requirement, then checks that the same request is accepted.CI: https://github.com/F64116045/ozone/actions/runs/40608672114
Co-authored-by: Codex (GPT-6)