Repository navigation
HDDS-17502. Report purgeable bytes split by deleted keys and directories in GetBucketDeletedBytes - #11799
Merged
Conversation
…ies in GetBucketDeletedBytes
sadanand48
reviewed
Oct 28, 2026
| assertEquals(1L, stats.getPurgeableKeys()); | ||
| assertEquals(0L, stats.getSnapshotTrappedDirs()); | ||
| assertEquals(1L, stats.getPurgeableDirs()); | ||
| assertEquals(0L, stats.getPurgeableKeyBytes()); |
Contributor
There was a problem hiding this comment.
can you please add a test when older OM replies with empty new fields
Member
Author
There was a problem hiding this comment.
Added test case for this.
sadanand48
approved these changes
Oct 29, 2026
sadanand48
left a comment
sadanand48
left a comment
Contributor
There was a problem hiding this comment.
Thanks @priyeshkaratha for the patch, LGTM
priyeshkaratha
marked this pull request as ready for review
October 29, 2026 04:17
Member
Author
|
Thanks @sadanand48 for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
BucketDeletedDataCalculator added bytes of deleted-table entries and of files under deleted directories into one purgeableBytes total, so callers could not tell the two apart.
Track purgeableKeyBytes and purgeableDirBytes separately and return them as new optional fields in GetBucketDeletedBytesResponse. purgeableBytes is still their sum. The client returns -1 for both when an older OM does not send them.
What is the link to the Apache JIRA
HDDS-17502
How was this patch tested?
updated test cases.