Repository navigation
HDDS-17387. Audit PERMISSION_DENIED rejected in preExecute of PutObjectTagging and DeleteObjectTagging - #11772
Merged
Merged
Conversation
sravani-revuri
left a comment
sravani-revuri
left a comment
Contributor
There was a problem hiding this comment.
Thanks @Gargi-jais11 for the patch, minor question below.
Gargi-jais11
marked this pull request as draft
October 29, 2026 04:30
Gargi-jais11
marked this pull request as ready for review
October 29, 2026 04:42
Contributor
|
Merged. Thanks @Gargi-jais11 @smengcl @chungen0126 @sarvekshayr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
PutObjectTagging and DeleteObjectTagging check ACLs in preExecute via resolveBucketAndCheckKeyAcls. A PERMISSION_DENIED is not audited, while S3BucketTaggingRequestBase already marks the preExecute failure for audit.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-17387
How was this patch tested?
Added unit tests.