Repository navigation
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ChenSammi
changed the title
|
|
||
| # Step 3: Compile and run tests to generate target/site/jacoco/jacoco.xml | ||
| - name: Execute Tests and Generate Reports | ||
| run: mvn clean test |
There was a problem hiding this comment.
We cannot add this, because:
- Running all tests in a single go takes several hours. That's why we run tests in splits.
- It duplicates work already being done in the integration check.
- It will result in unexpectedly low coverage, since acceptance tests are completely ignored.
|
|
||
| # Step 4: Run the Madrapps Action to find and match the git diff | ||
| - name: Generate and Post Diff Coverage Report | ||
| uses: madrapps/jacoco-report@50d3aff4548aa991e6753342d9ba291084e63848 |
There was a problem hiding this comment.
The action madrapps/jacoco-report@50d3aff4548aa991e6753342d9ba291084e63848 is not allowed in apache/ozone because all actions must be from a repository owned by your enterprise, created by GitHub, or
or be whitelisted in https://github.com/apache/infrastructure-actions/blob/main/actions.yml
| @Override | ||
| public boolean checkReadWrite(File storageDir, | ||
| File testFileDir, int numBytesToWrite) { | ||
| File testFile = new File(testFileDir, "disk-check-" + UUID.randomUUID()); |
There was a problem hiding this comment.
how do we clean up disk-check-* files?
There was a problem hiding this comment.
@yandrey321 Please review #9972, which this PR duplicates just for experimenting with PR Diff Coverage Verification workflow.
adoroszlai
changed the title
|
This PR has been marked as stale due to 21 days of inactivity. Please comment or remove the stale label to keep it open. Otherwise, it will be automatically closed in 7 days. |
|
This PR has been marked as stale due to 21 days of inactivity. Please comment or remove the stale label to keep it open. Otherwise, it will be automatically closed in 7 days. |
|
Thank you for your contribution. This PR is being closed due to inactivity. Please contact a maintainer if you would like to reopen it. |
What changes were proposed in this pull request?
experiment with PR coverage calculation