sched/wqueue: Fix work_cancel() to return -ENOENT when no such work is queued - #20046
Open
szafonimateusz-mi wants to merge 1 commit into
Open
sched/wqueue: Fix work_cancel() to return -ENOENT when no such work is queued#20046szafonimateusz-mi wants to merge 1 commit into
szafonimateusz-mi wants to merge 1 commit into
Conversation
github-actions
Bot
added
Area: OS Components
|
…s queued. Fix work_cancel() to return -ENOENT when no such work is queued. Signed-off-by: wushenhui <wushenhui@xiaomi.com>
raiden00pl
force-pushed
the
kwork_cancel
branch
from
September 2, 2026 17:36
4f1b3f3 to
babef3d
Compare
| } | ||
| else | ||
| { | ||
| ret = -ENOENT; |
Contributor
There was a problem hiding this comment.
why not return, but to through the remaining code
Member
There was a problem hiding this comment.
early return will change the behavior of this function for sync path. I haven't analyzed the consequences of this, so no early return.
Contributor
There was a problem hiding this comment.
ok, but why return -ENOENT in this case? it's fine to return OK if work isn't queued yet since the final result is that the work doesn't fire anyway.
acassis
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix work_cancel() to return -ENOENT when no such work is queued
Impact
required to pass intel64 LTP tests
Testing
NTFC