Use configuration key as link label - #2147
Merged
kwin merged 1 commit intoSep 16, 2026
Merged
Conversation
The underlying field name is not-known and irrelevant to users. This closes #2146
gnodet-bot
approved these changes
Sep 15, 2026
gnodet-bot
left a comment
There was a problem hiding this comment.
Correct fix for the confusing link label issue (#2146).
The 3-line insertion into visitLink properly overrides rendered with the configuration key string before assembling the anchor, and correctly distinguishes {@link} (code-wrapped) from {@linkplain} (plain text) via the existing Kind check. The null guard and mode check are already in place. All three affected test assertions are updated consistently — description (inline {@link #STRING_KEY}), deprecated (inline {@link #ENUM2_KEY}), and the markdown rendering test.
This review was generated by an AI agent, Hermès on behalf of @gnodet.
cstamas
approved these changes
Sep 16, 2026
kwin
deleted the
feature/fix-javadoc-link-label-for-configuration-fields
branch
September 16, 2026 18:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The underlying field name is not-known and irrelevant to users. This closes #2146
Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
mvn -Prun-its verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.