Skip to content

fix: mng-0479 IT fix #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cstamas merged 1 commit into from
Nov 4, 2026
Merged

fix: mng-0479 IT fix #458

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions core-it-suite/src/test/java/org/apache/maven/it/MavenITmng0479OverrideCentralRepoTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,16 @@ public MavenITmng0479OverrideCentralRepoTest() {
public void testitModel() throws Exception {
File testDir = ResourceExtractor.simpleExtractResources(getClass(), "/mng-0479");

// Note: starting with Resolver 2.0.25 that contains this fix https://github.com/apache/maven-resolver/pull/2192
// this IT as is, pass-ok with 3.10.0, but it fails with 3.10.1 (Resolver 2.0.25) due that pull request above.
// The fix in PR pulls out all repositories for consideration, as central is redefined as snapshot repository!
// Hence, added a fix that works for both, 3.10.0 and 3.10.1+: added second "alt central" that points to real
// Central, as after PR 2192, there is no more "way" to trick Maven, it is now strict.
//
// History: This IT is for MNG-479, but later was "refurbished" for MNG-4769, where the override of Central
// to "snapshot only" was added (and relevant assertions). Hence, the workaround above, as it leave all
// those things in place, but also makes IT pass with 3.10.1+

// Phase 1: Ensure the test plugin is downloaded before the test cuts off access to central
File child1 = new File(testDir, "setup");
Verifier verifier = newVerifier(child1.getAbsolutePath());
Expand Down
26 changes: 26 additions & 0 deletions core-it-suite/src/test/resources/mng-0479/test/settings-template.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,19 @@ under the License.
<updatePolicy>never</updatePolicy>
</snapshots>
</repository>
<repository>
<id>alt-central</id>
<name>alt-central-mng-0479</name>
<url>https://repo1.maven.org/maven2</url>
<releases>
<enabled>true</enabled>
<checksumPolicy>fail</checksumPolicy>
<updatePolicy>never</updatePolicy>
</releases>
<snapshots>
<enabled>false</enabled>
</snapshots>
</repository>
</repositories>
<pluginRepositories>
<pluginRepository>
Expand All @@ -62,6 +75,19 @@ under the License.
<updatePolicy>never</updatePolicy>
</snapshots>
</pluginRepository>
<pluginRepository>
<id>alt-central</id>
<name>alt-central-mng-0479</name>
<url>https://repo1.maven.org/maven2</url>
<releases>
<enabled>true</enabled>
<checksumPolicy>fail</checksumPolicy>
<updatePolicy>never</updatePolicy>
</releases>
<snapshots>
<enabled>false</enabled>
</snapshots>
</pluginRepository>
</pluginRepositories>
</profile>
</profiles>
Expand Down
Loading